feat(docs): update callouts to include icon attribute #1597
Conversation
chdeskur
had a problem deploying
to
Preview - app.buildwithfern.com
GitHub Actions
Error
chdeskur
had a problem deploying
to
Preview - app-dev.buildwithfern.com
GitHub Actions
Error
Playwright test results
Details
|
📦 Next.js Bundle Analysis for fern-platform-monorepoThis analysis was generated by the Next.js Bundle Analysis action. 🤖 🎉 Global Bundle Size Decreased
DetailsThe global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster. Any third party scripts you have added directly to your app using the If you want further insight into what is behind the changes, give @next/bundle-analyzer a try! New Page AddedThe following page was added to the bundle from the code in this PR:
Two Pages Changed SizeThe following pages changed size from the code in this PR compared to its base branch:
DetailsOnly the gzipped size is provided here based on an expert tip. First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If Any third party scripts you have added directly to your app using the The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored. |
Playwright test results
Details
|
| @@ -101,65 +101,85 @@ export const Callout: FC<PropsWithChildren<Callout.Props>> = ({ intent: intentRa | |||
|
|
|||
| // aliases | |||
|
|
|||
| export function InfoCallout({ children, title }: PropsWithChildren<Omit<Callout.Props, "intent">>): ReactElement { | |||
| export function InfoCallout({ children, title, icon }: PropsWithChildren<Omit<Callout.Props, "intent">>): ReactElement { | |||
There was a problem hiding this comment.
you can also just spread the props in case new props are ever added in the future
change { children, title, icon } to { children, ...props }
<Callout intent="info" {...props}>
{children}
</Callout>
This PR adds the
iconattribute to the Callout options so that custom icons can be used in the various Callout-styled components.The example below tests the PR using a custom icon with the components