feat: tree-aware version switcher #1593
Conversation
Playwright test results
Details
|
📦 Next.js Bundle Analysis for fern-platform-monorepoThis analysis was generated by the Next.js Bundle Analysis action. 🤖 🎉 Global Bundle Size Decreased
DetailsThe global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster. Any third party scripts you have added directly to your app using the If you want further insight into what is behind the changes, give @next/bundle-analyzer a try! New Page AddedThe following page was added to the bundle from the code in this PR:
Two Pages Changed SizeThe following pages changed size from the code in this PR compared to its base branch:
DetailsOnly the gzipped size is provided here based on an expert tip. First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If Any third party scripts you have added directly to your app using the The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored. |
Playwright test results
Details
|
packages/ui/docs-bundle/src/server/__test__/withVersionSwitcherInfo.test.ts
Show resolved
Hide resolved
| * | ||
| * ASSUMPTIONS: | ||
| * This function relies on the slug and parent slugs to match between the versions. | ||
| * If the slug is overridden in frontmatter, there is not currently a way to determine the correct slug to switch to. |
There was a problem hiding this comment.
how would we solve this edge case? (sounds like you would need to traverse nodes in the navigation?)
This PR enhances the previous implementation of the version switcher, where previously it only checks if the current node exists across versions. Now it will also ascend the tree and check if its parents exist across versions.
This allows the user to stay inside the same navigational "context" even if the current node doesn't exist across versions. For example:
nodeandparentsinto a ascending tree-list is unit tested