Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: implement anchor logic in long scrolling changelog #1467

Merged
merged 3 commits into from
Sep 12, 2024

Conversation

abvthecity
Copy link
Contributor

@abvthecity abvthecity commented Sep 12, 2024

humanloop released a newsletter with an anchor link to the changelog page. since we've implemented pagination, that link will be broken if it's on a page > 1. this PR attempts to solve that challenge by opening the correct page of the changelog immediately

@abvthecity abvthecity marked this pull request as ready for review September 12, 2024 21:13
Copy link

vercel bot commented Sep 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
app.buildwithfern.com ✅ Ready (Inspect) Visit Preview Sep 12, 2024 9:43pm
fern-dashboard-dev ✅ Ready (Inspect) Visit Preview Sep 12, 2024 9:43pm
6 Skipped Deployments
Name Status Preview Updated (UTC)
app-dev.buildwithfern.com ⬜️ Ignored (Inspect) Visit Preview Sep 12, 2024 9:43pm
app-slash.ferndocs.com ⬜️ Ignored (Inspect) Visit Preview Sep 12, 2024 9:43pm
app.ferndocs.com ⬜️ Ignored (Inspect) Visit Preview Sep 12, 2024 9:43pm
fern-dashboard ⬜️ Ignored (Inspect) Sep 12, 2024 9:43pm
fern-middleware-rewrite-test ⬜️ Ignored (Inspect) Visit Preview Sep 12, 2024 9:43pm
fontawesome-cdn ⬜️ Ignored (Inspect) Visit Preview Sep 12, 2024 9:43pm

@abvthecity abvthecity enabled auto-merge (squash) September 12, 2024 21:13
Copy link

📦 Next.js Bundle Analysis for fern-platform-monorepo

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

1 similar comment
Copy link

📦 Next.js Bundle Analysis for fern-platform-monorepo

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@abvthecity abvthecity merged commit 6f35dc1 into main Sep 12, 2024
17 of 24 checks passed
@abvthecity abvthecity deleted the ajiang/paginated-anchors-in-changelog branch September 12, 2024 21:34
Copy link

📦 Next.js Bundle Analysis for fern-platform-monorepo

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants