improvement: create a snippet resolver that caches the api definition… #1232
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… across
Short description of the changes made
This PR introduces a definition holder wrapping the snippet template resolver, allowing us to only request the api definition once per-api definition ID
Essentially just:
SnippetTemplateResolutionHolder
with a definition or definition IDresolve
as you would have instantiated aSnippetTemplateResolver
beforeex:
What was the motivation & context behind this PR?
Limit calls to FDR for getting the API definition, necessary to resolve Union templates