Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: noUncheckedIndexedAccess=true on fern docs #1219

Merged
merged 3 commits into from
Jul 30, 2024
Merged

Conversation

abvthecity
Copy link
Contributor

@abvthecity abvthecity commented Jul 30, 2024

Fixes FER-2721

Short description of the changes made

  • set noUncheckedIndexedAccess to true
  • fixed compilation failures
  • ignore generateRadixColors (because this logic was copied from radix)

What was the motivation & context behind this PR?

follow up to #1214

How has this PR been tested?

ci checks

Copy link

vercel bot commented Jul 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fern-dashboard-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 30, 2024 6:40pm
fern-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 30, 2024 6:40pm
fern-prod ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 30, 2024 6:40pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
fern-dashboard ⬜️ Ignored (Inspect) Jul 30, 2024 6:40pm
fontawesome-cdn ⬜️ Ignored (Inspect) Visit Preview Jul 30, 2024 6:40pm
private-docs ⬜️ Ignored (Inspect) Jul 30, 2024 6:40pm

@abvthecity abvthecity marked this pull request as ready for review July 30, 2024 15:20
@abvthecity abvthecity changed the title fix: noUncheckedIndexedAccess=true fix: noUncheckedIndexedAccess=true on fern docs Jul 30, 2024
@abvthecity abvthecity enabled auto-merge (squash) July 30, 2024 17:06
Copy link

linear bot commented Jul 30, 2024

}),
});
} else {
// TODO: alert if the page is null
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should file a ticket if this is important

@abvthecity abvthecity merged commit 08e19d9 into main Jul 30, 2024
21 checks passed
@abvthecity abvthecity deleted the ajiang/fix-nullchecks branch July 30, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants