Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include 'alt' attribute for the logo #1216

Conversation

sulaiman-fern
Copy link
Contributor

Fixes FER-2639

Short description of the changes made

Include the title of the company as the alt attribute for the site logo

What was the motivation & context behind this PR?

Uploadcare wanted to include an alt attribute for company logo.

How has this PR been tested?

Screenshot below shows the alt attribute being set on the logo

Screenshot 2024-07-29 at 7 09 23 PM

Copy link

linear bot commented Jul 29, 2024

FER-2639 [Uploadcare] Can we provide an "alt" attribute for the logo with a description like "Uploadcare logo" or "Uploadcare homepage logo"?

rsedykh said:

Can we define alt for the logo? E.g. to have there alt="Uploadcare logo" / alt="Uploadcare homepage logo"

Copy link

vercel bot commented Jul 29, 2024

Someone is attempting to deploy this pull request to the fern Team on Vercel.

To accomplish this, the commit author's email address needs to be associated with a GitHub account.

Learn more about how to change the commit author information.

@sulaiman-fern sulaiman-fern marked this pull request as ready for review July 29, 2024 23:15
Copy link

vercel bot commented Jul 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fern-dashboard-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 30, 2024 6:44pm
fern-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 30, 2024 6:44pm
fern-prod ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 30, 2024 6:44pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
fontawesome-cdn ⬜️ Ignored (Inspect) Visit Preview Jul 30, 2024 6:44pm
private-docs ⬜️ Ignored (Inspect) Jul 30, 2024 6:44pm

@abvthecity abvthecity enabled auto-merge (squash) July 30, 2024 18:35
@abvthecity abvthecity merged commit 98161dc into main Jul 30, 2024
19 of 21 checks passed
@abvthecity abvthecity deleted the sulaiman/fer-2639-uploadcare-can-we-provide-an-alt-attribute-for-the-logo-with branch July 30, 2024 18:40
sulaiman-fern added a commit that referenced this pull request Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants