Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: clicking sidebar link should not open in a new tab if relative url #1208

Conversation

abvthecity
Copy link
Contributor

@abvthecity abvthecity commented Jul 26, 2024

Fixes FER-2644

<SidebarLink> wraps <FernLink> which checks if the url is internal or external.

Copy link

linear bot commented Jul 26, 2024

Copy link

vercel bot commented Jul 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fern-dashboard-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 26, 2024 6:18pm
fern-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 26, 2024 6:18pm
fern-prod ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 26, 2024 6:18pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
fern-dashboard ⬜️ Ignored (Inspect) Jul 26, 2024 6:18pm
fontawesome-cdn ⬜️ Ignored (Inspect) Visit Preview Jul 26, 2024 6:18pm
private-docs ⬜️ Ignored (Inspect) Jul 26, 2024 6:18pm

@abvthecity abvthecity marked this pull request as ready for review July 26, 2024 18:04
@abvthecity abvthecity merged commit 4d7e236 into main Jul 26, 2024
19 of 21 checks passed
@abvthecity abvthecity deleted the andrew/fer-2644-workato-boundary-relative-path-linking-in-the-sidebar-should branch July 26, 2024 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants