fix: urljoin on basepath #1207
Merged
fix: urljoin on basepath #1207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
RohinBhargava
approved these changes
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes FER-2475
Short description of the changes made
basepath fallsback to
"/"in urljoinWhat was the motivation & context behind this PR?
urljoin("", "/path")yields"path"urljoin("/", "/path")yields"/path"urljoin("/basepath", "/path")yields"/basepath/path"useSWR fallback in getDocsPageProps is storing key
api/fern-docs/search, meanwhile useSWR is fetching/current/path/to/page/api/fern-docs/searchbecause it's fetching on the relative path.How has this PR been tested?
This is a noop fix 👍