Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: map update in the api playground #1206

Merged
merged 1 commit into from
Jul 26, 2024
Merged

Conversation

abvthecity
Copy link
Contributor

@abvthecity abvthecity commented Jul 26, 2024

Fixes FER-2399, FER-2637

Short description of the changes made

  • api playground state update is not typesafe— map form onChange handler will now check if the onChange event is potentially a dispatch (callback)

What was the motivation & context behind this PR?

https://buildwithfern.slack.com/archives/C073J6QBX1V/p1720620268434399

How has this PR been tested?

spun up a dev URL and tested locally: https://rightbrain.docs.dev.buildwithfern.com/api-reference/tasks/create-task

Copy link

linear bot commented Jul 26, 2024

FER-2399 [Hume, Rightbrain] Update method does not allow value updates, only key additions

Pete said:

also for the update method, it only allows you add a key, but the value remains blank so you cant update

@abvthecity abvthecity marked this pull request as ready for review July 26, 2024 15:42
Copy link

vercel bot commented Jul 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fern-dashboard-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 26, 2024 3:45pm
fern-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 26, 2024 3:45pm
fern-prod ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 26, 2024 3:45pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
fern-dashboard ⬜️ Ignored (Inspect) Jul 26, 2024 3:45pm
fontawesome-cdn ⬜️ Ignored (Inspect) Jul 26, 2024 3:45pm
private-docs ⬜️ Ignored (Inspect) Jul 26, 2024 3:45pm

Copy link

linear bot commented Jul 26, 2024

FER-2637 [Monite] Small issue with the front-end of the API Playground: closed dropdowns of union fields should show the selected option

Helen Kosova said:

Small FE issue - API Playground - closed dropdowns of union fields should indicate the selected option

@abvthecity abvthecity merged commit 013b849 into main Jul 26, 2024
21 checks passed
@abvthecity abvthecity deleted the ajiang/fix-map-update branch July 26, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants