Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add body to 403 Operations in FDR #1188

Merged
merged 11 commits into from
Jul 24, 2024

Conversation

RohinBhargava
Copy link
Member

@RohinBhargava RohinBhargava commented Jul 24, 2024

Short description of the changes made

  • Adds type of string to the two 403 Error codes.

What was the motivation & context behind this PR?

  • When there is no body provided for 403, the client fetcher cannot properly parse the "Forbidden" content. The reason this is, when only sending sendStatus, no content-type is set. An alternate change could be that if no type is detected for an error, we add a text content-type header when generating the typescript server stub.

How has this PR been tested?

Screenshot 2024-07-23 at 8 56 10 PM

@RohinBhargava RohinBhargava requested a review from dsinghvi as a code owner July 24, 2024 01:09
Copy link

vercel bot commented Jul 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fern-dashboard-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 24, 2024 1:18am
fern-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 24, 2024 1:18am
fern-prod ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 24, 2024 1:18am
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
fern-dashboard ⬜️ Ignored (Inspect) Jul 24, 2024 1:18am
fontawesome-cdn ⬜️ Ignored (Inspect) Visit Preview Jul 24, 2024 1:18am
private-docs ⬜️ Ignored (Inspect) Jul 24, 2024 1:18am

@RohinBhargava RohinBhargava requested a review from abvthecity July 24, 2024 01:09
Copy link

Copy link

@RohinBhargava
Copy link
Member Author

The right thing to do is to add the text content-type when generating; making a follow up ticket

@RohinBhargava RohinBhargava merged commit 9d189ec into main Jul 24, 2024
23 checks passed
@RohinBhargava RohinBhargava deleted the rohin/syndicate-forbidden-error-message branch July 24, 2024 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants