Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hide hidden and noindex pages from sitemap #1175

Merged
merged 5 commits into from
Jul 23, 2024
Merged

Conversation

abvthecity
Copy link
Contributor

@abvthecity abvthecity commented Jul 22, 2024

Fixes FER-2522

Before this PR:

  • hidden and noindex pages are included in the sitemap

After this PR:

  • hidden and noindex pages are excluded from the sitemap
  • nodes inherit "hidden" from parents. i.e. if a section is hidden, all of its children become hidden as well.

See here for why noindex pages should also be excluded from sitemap.

Copy link

vercel bot commented Jul 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fern-dashboard-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 23, 2024 0:22am
fern-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 23, 2024 0:22am
fern-prod ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 23, 2024 0:22am
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
fern-dashboard ⬜️ Ignored (Inspect) Jul 23, 2024 0:22am
fontawesome-cdn ⬜️ Ignored (Inspect) Visit Preview Jul 23, 2024 0:22am
private-docs ⬜️ Ignored (Inspect) Jul 23, 2024 0:22am

Copy link

@abvthecity abvthecity marked this pull request as ready for review July 22, 2024 21:36
@abvthecity abvthecity requested a review from dsinghvi as a code owner July 22, 2024 21:36
Copy link

Copy link

Copy link

linear bot commented Jul 22, 2024

FER-2522 [Cohere] Exclude hidden pages from the sitemap XML

Currently, Fern's sitemap XML includes locations for hidden pages (like docs/setting-up). Cohere's existing sitemap does not. We should exclude hidden pages from the sitemap.

Copy link

Copy link

@abvthecity abvthecity merged commit 8553162 into main Jul 23, 2024
24 checks passed
@abvthecity abvthecity deleted the ajiang/fix-sitemap branch July 23, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants