Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip: transition fern-bot to use step functions #1033

Merged
merged 16 commits into from
Jun 21, 2024
Merged

Conversation

armandobelardo
Copy link
Contributor

@armandobelardo armandobelardo commented Jun 17, 2024

Fixes: FER-1831

Trying this out, but will otherwise make a lambda that triggers a bunch of other instances of another lambda

The general idea: take advantage of aws lambda step functions
First lambda, runs on schedule:

  • Run through the Github app installations and create a new "dataset" in s3 that has the necessary data to run the subsequent actions
    Second lambda, runs as a follow on step to the first lambda, triggered automatically:
  • Type: Map, meaning it can take a dataset in s3 and parallelize the execution of a lambda on each individual record of the dataset
  • Runs the existing update action, but instead of looping over the repos, expects repo data to be passed in as a payload (e.g. from the s3 dataset)

Copy link

vercel bot commented Jun 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fern-dashboard-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 21, 2024 3:36pm
fern-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 21, 2024 3:36pm
fern-prod ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 21, 2024 3:36pm
2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
fontawesome-cdn ⬜️ Ignored (Inspect) Visit Preview Jun 21, 2024 3:36pm
private-docs ⬜️ Ignored (Inspect) Jun 21, 2024 3:36pm

@armandobelardo armandobelardo marked this pull request as ready for review June 21, 2024 13:56
@armandobelardo armandobelardo requested a review from dsinghvi as a code owner June 21, 2024 13:56
Copy link
Member

@dsinghvi dsinghvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple questions:

  • What repos do we store in s3 (all or just ones with fern folders?)
  • Would be great to have an end-to-end test that runs to make sure PRs get created (we can setup a demo repo to do this as well)

@armandobelardo
Copy link
Contributor Author

@dsinghvi

  1. all the ones fern bot is installed on, the thought there is that this first step can be used to multi-plex to whatever jobs we want to add without having to reinvent the wheel
  2. sure will add

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants