Skip to content

Commit

Permalink
Merge branch 'main' into bsinghvi/cache-updates
Browse files Browse the repository at this point in the history
  • Loading branch information
bsinghvi committed May 2, 2024
2 parents a35a31a + a07443e commit e6d5432
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion .github/pull_request_template.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
Fixes ENG-
Fixes FER-

## Short description of the changes made

Expand Down
2 changes: 1 addition & 1 deletion servers/fdr-deploy/scripts/elasticache-stack.ts
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,6 @@ export class ElastiCacheStack extends Stack {
);

new CfnOutput(this, `${props.cacheName}Host`, { value: this.redisEndpointAddress });
new CfnOutput(this, `${props.cacheName}Po`, { value: this.redisEndpointPort });
new CfnOutput(this, `${props.cacheName}Port`, { value: this.redisEndpointPort });
}
}
6 changes: 3 additions & 3 deletions servers/fdr-deploy/scripts/fdr-deploy-stack.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import { IVpc, Peer, Port, SecurityGroup, Vpc } from "aws-cdk-lib/aws-ec2";
import { Cluster, ContainerImage, LogDriver, Volume } from "aws-cdk-lib/aws-ecs";
import { ApplicationLoadBalancedFargateService } from "aws-cdk-lib/aws-ecs-patterns";
import { CfnReplicationGroup, CfnSubnetGroup } from "aws-cdk-lib/aws-elasticache";
import { ApplicationProtocol, HttpCodeTarget } from "aws-cdk-lib/aws-elasticloadbalancingv2";
import { ApplicationProtocol, HttpCodeElb } from "aws-cdk-lib/aws-elasticloadbalancingv2";
import { LogGroup } from "aws-cdk-lib/aws-logs";
import { ARecord, HostedZone, RecordTarget } from "aws-cdk-lib/aws-route53";
import { LoadBalancerTarget } from "aws-cdk-lib/aws-route53-targets";
Expand Down Expand Up @@ -89,7 +89,7 @@ export class FdrDeployStack extends Stack {
versioned: true,
});

const fernDocsCacheEndpoint = this.constructElastiCacheInstance(scope, {
const fernDocsCacheEndpoint = this.constructElastiCacheInstance(this, {
cacheName: "FernDocsCache",
IVpc: vpc,
numCacheShards: 1,
Expand Down Expand Up @@ -215,7 +215,7 @@ export class FdrDeployStack extends Stack {

const lb500CountAlarm = new Alarm(this, "fdr-lb-5XX-count", {
alarmName: `${id} Load Balancer 500 Error Alarm`,
metric: fargateService.loadBalancer.metrics.httpCodeTarget(HttpCodeTarget.TARGET_5XX_COUNT),
metric: fargateService.loadBalancer.metrics.httpCodeElb(HttpCodeElb.ELB_5XX_COUNT),
threshold: 2,
evaluationPeriods: 5,
});
Expand Down

0 comments on commit e6d5432

Please sign in to comment.