Skip to content

Commit

Permalink
fix: depcheck issue (#2079)
Browse files Browse the repository at this point in the history
  • Loading branch information
abvthecity authored Jan 24, 2025
1 parent 1a8125c commit 81ee2b8
Show file tree
Hide file tree
Showing 29 changed files with 92 additions and 92 deletions.
2 changes: 1 addition & 1 deletion clis/generator-cli/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
"@types/node": "^18.7.18",
"@types/yargs": "^17.0.32",
"@yarnpkg/esbuild-plugin-pnp": "^3.0.0-rc.15",
"depcheck": "^1.4.3",
"depcheck": "^1.4.7",
"esbuild": "0.20.2",
"eslint": "^9",
"execa": "^9.5.1",
Expand Down
2 changes: 1 addition & 1 deletion clis/vercel-scripts/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
"@fern-platform/configs": "workspace:*",
"@types/node": "^18.7.18",
"@types/yargs": "^17.0.32",
"depcheck": "^1.4.3",
"depcheck": "^1.4.7",
"eslint": "^9",
"prettier": "^3.4.2",
"tsx": "^4.7.1",
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@
"@typescript-eslint/parser": "8.18.1",
"@yarnpkg/sdks": "^3.1.0",
"chalk": "^5.3.0",
"depcheck": "^1.4.3",
"depcheck": "^1.4.7",
"dotenv": "^16.4.5",
"eslint": "^9",
"eslint-config-next": "15.1.2",
Expand Down
2 changes: 1 addition & 1 deletion packages/commons/core-utils/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@
"@types/node": "^18.7.18",
"@types/title": "^3.4.3",
"@types/ua-parser-js": "^0.7.39",
"depcheck": "^1.4.3",
"depcheck": "^1.4.7",
"eslint": "^9",
"prettier": "^3.4.2",
"stylelint": "^16.1.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/commons/fdr-utils/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
"devDependencies": {
"@fern-platform/configs": "workspace:*",
"@types/node": "^18.7.18",
"depcheck": "^1.4.3",
"depcheck": "^1.4.7",
"eslint": "^9",
"prettier": "^3.4.2",
"stylelint": "^16.1.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/commons/github/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@
"devDependencies": {
"@fern-platform/configs": "workspace:*",
"@types/node": "^18.7.18",
"depcheck": "^1.4.3",
"depcheck": "^1.4.7",
"eslint": "^9",
"prettier": "^3.4.2",
"simple-git": "^3.24.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/commons/loadable/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
"devDependencies": {
"@fern-platform/configs": "workspace:*",
"@types/node": "^18.7.18",
"depcheck": "^1.4.3",
"depcheck": "^1.4.7",
"eslint": "^9",
"prettier": "^3.4.2",
"stylelint": "^16.1.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/commons/react-commons/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
"@fern-platform/configs": "workspace:*",
"@types/node": "^18.7.18",
"@types/react": "^18",
"depcheck": "^1.4.3",
"depcheck": "^1.4.7",
"eslint": "^9",
"prettier": "^3.4.2",
"stylelint": "^16.1.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/fern-docs/auth/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
"devDependencies": {
"@fern-platform/configs": "workspace:*",
"@types/node": "^18.7.18",
"depcheck": "^1.4.3",
"depcheck": "^1.4.7",
"eslint": "^9",
"prettier": "^3.4.2",
"stylelint": "^16.1.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/fern-docs/bundle/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@
"@types/react": "^18",
"@types/react-dom": "^18",
"autoprefixer": "^10.4.16",
"depcheck": "^1.4.3",
"depcheck": "^1.4.7",
"eslint": "^9",
"glslify-import": "^3.1.0",
"glslify-loader": "^2.0.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/fern-docs/cache/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@
"devDependencies": {
"@fern-platform/configs": "workspace:*",
"@types/node": "^18.7.18",
"depcheck": "^1.4.3",
"depcheck": "^1.4.7",
"eslint": "^9",
"prettier": "^3.4.2",
"stylelint": "^16.1.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/fern-docs/components/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@
"@vitejs/plugin-react": "^4.2.1",
"autoprefixer": "^10.4.16",
"chromatic": "^11.3.0",
"depcheck": "^1.4.3",
"depcheck": "^1.4.7",
"eslint": "^9",
"eslint-plugin-storybook": "^0.8.0",
"jsdom": "^24.0.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/fern-docs/edge-config/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@
"@fern-docs/search-utils": "workspace:*",
"@fern-platform/configs": "workspace:*",
"@types/node": "^18.7.18",
"depcheck": "^1.4.3",
"depcheck": "^1.4.7",
"eslint": "^9",
"prettier": "^3.4.2",
"stylelint": "^16.1.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/fern-docs/icons-cdn/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@
"@next/bundle-analyzer": "14.2.9",
"@types/node": "^18.7.18",
"@types/react": "^18",
"depcheck": "^1.4.3",
"depcheck": "^1.4.7",
"eslint": "^9",
"next": "npm:@fern-api/[email protected]",
"prettier": "^3.4.2",
Expand Down
2 changes: 1 addition & 1 deletion packages/fern-docs/local-preview-bundle/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@
"@types/react": "^18",
"@types/react-dom": "^18",
"autoprefixer": "^10.4.16",
"depcheck": "^1.4.3",
"depcheck": "^1.4.7",
"eslint": "^9",
"express": "^4.21.2",
"glslify-import": "^3.1.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/fern-docs/mdx/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@
"devDependencies": {
"@fern-platform/configs": "workspace:*",
"@types/node": "^18.7.18",
"depcheck": "^1.4.3",
"depcheck": "^1.4.7",
"eslint": "^9",
"prettier": "^3.4.2",
"stylelint": "^16.1.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/fern-docs/search-server/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@
"@types/html-to-text": "^9.0.1",
"@types/marked": "^5.0.0",
"@types/node": "^18.7.18",
"depcheck": "^1.4.3",
"depcheck": "^1.4.7",
"eslint": "^9",
"prettier": "^3.4.2",
"stylelint": "^16.1.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/fern-docs/search-utils/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
"@fern-platform/configs": "workspace:*",
"@inkeep/widgets": "^0.2.288",
"@types/node": "^18.7.18",
"depcheck": "^1.4.3",
"depcheck": "^1.4.7",
"eslint": "^9",
"instantsearch.js": "^4.75.4",
"prettier": "^3.4.2",
Expand Down
2 changes: 1 addition & 1 deletion packages/fern-docs/seo/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@
"@fern-platform/fdr-utils": "workspace:*",
"@types/node": "^18.7.18",
"@types/react": "^18",
"depcheck": "^1.4.3",
"depcheck": "^1.4.7",
"eslint": "^9",
"prettier": "^3.4.2",
"stylelint": "^16.1.0",
Expand Down
1 change: 0 additions & 1 deletion packages/fern-docs/ui/.depcheckrc.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
"@types/node",
"vite",
"@types/react",
"@types/react",
"@types/react-dom",
"@radix-ui/colors",
"autoprefixer",
Expand Down
2 changes: 1 addition & 1 deletion packages/fern-docs/ui/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@
"@vitejs/plugin-react": "^4.2.1",
"autoprefixer": "^10.4.16",
"chromatic": "^11.3.0",
"depcheck": "^1.4.3",
"depcheck": "^1.4.7",
"eslint": "^9",
"eslint-plugin-storybook": "^0.8.0",
"express": "^4.21.2",
Expand Down
40 changes: 38 additions & 2 deletions packages/fern-docs/ui/src/atoms/docs.ts
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
import { DocsV1Read } from "@fern-api/fdr-sdk";
import * as FernNavigation from "@fern-api/fdr-sdk/navigation";
import { DEFAULT_EDGE_FLAGS } from "@fern-docs/utils";
import { atomWithReducer, useHydrateAtoms } from "jotai/utils";
import { isEqual } from "es-toolkit/predicate";
import { atomWithReducer, selectAtom, useHydrateAtoms } from "jotai/utils";
import type { PropsWithChildren, ReactNode } from "react";
import type { DocsProps } from "./types";
import type { DocsProps, JsConfig } from "./types";

export const EMPTY_ANALYTICS_CONFIG: DocsV1Read.AnalyticsConfig = {
segment: undefined,
Expand Down Expand Up @@ -99,3 +100,38 @@ export function HydrateAtoms({
});
return children;
}

export const JS_ATOM = selectAtom(DOCS_ATOM, (docs) => docs.js, isEqual);

export function withCustomJavascript(
readShapeJsConfig: DocsV1Read.JsConfig | undefined,
resolveFileSrc: (fileId: string) => { src: string } | undefined
): JsConfig | undefined {
const remote = [
...(readShapeJsConfig?.remote ?? []),
...(readShapeJsConfig?.files ?? []).map((file) => ({
url: resolveFileSrc(file.fileId)?.src,
strategy: file.strategy,
})),
].filter(isRemote);

const toRet = {
inline: readShapeJsConfig?.inline,
remote: remote.length > 0 ? remote : undefined,
};

if (!toRet.inline && !toRet.remote) {
return undefined;
}

return toRet;
}

type RemoteJs = NonNullable<JsConfig["remote"]>[number];

function isRemote(remote: {
url: string | undefined; // potentially undefined if the file is not found
strategy: RemoteJs["strategy"];
}): remote is RemoteJs {
return remote.url != null;
}
9 changes: 7 additions & 2 deletions packages/fern-docs/ui/src/atoms/index.ts
Original file line number Diff line number Diff line change
@@ -1,10 +1,15 @@
export * from "./announcement";
export * from "./apis";
export * from "./auth";
export * from "./docs";
export {
DOCS_ATOM,
EMPTY_ANALYTICS_CONFIG,
EMPTY_DOCS_STATE,
HydrateAtoms,
JS_ATOM,
} from "./docs";
export * from "./flags";
export * from "./hooks";
export { JS_ATOM } from "./js";
export * from "./lang";
export * from "./layout";
export * from "./location";
Expand Down
40 changes: 0 additions & 40 deletions packages/fern-docs/ui/src/atoms/js.ts

This file was deleted.

2 changes: 1 addition & 1 deletion packages/fern-docs/ui/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ export type {
LogoConfiguration,
NavbarLink,
} from "./atoms";
export { withCustomJavascript } from "./atoms/js";
export { withCustomJavascript } from "./atoms/docs";
export { withLogo } from "./atoms/logo";
export * from "./docs/DocsPage";
export * from "./docs/NextApp";
Expand Down
2 changes: 1 addition & 1 deletion packages/fern-docs/utils/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@
"devDependencies": {
"@fern-platform/configs": "workspace:*",
"@types/node": "^18.7.18",
"depcheck": "^1.4.3",
"depcheck": "^1.4.7",
"eslint": "^9",
"prettier": "^3.4.2",
"stylelint": "^16.1.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/healthchecks/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@
"@types/node": "^18.7.18",
"@types/yargs": "^17.0.32",
"@yarnpkg/esbuild-plugin-pnp": "^3.0.0-rc.15",
"depcheck": "^1.4.3",
"depcheck": "^1.4.7",
"esbuild": "0.20.2",
"eslint": "^9",
"prettier": "^3.4.2",
Expand Down
2 changes: 1 addition & 1 deletion packages/scripts/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
"@types/js-yaml": "^4.0.5",
"@types/node": "^18.7.18",
"@types/yargs": "^17.0.32",
"depcheck": "^1.4.3",
"depcheck": "^1.4.7",
"eslint": "^9",
"prettier": "^3.4.2",
"typescript": "^5",
Expand Down
Loading

0 comments on commit 81ee2b8

Please sign in to comment.