Change section to div and remove unnecessary aside within layout (#1227)

Co-authored-by: Andrew Jiang <[email protected]>
fern-api · Aug 1, 2024 · 6eb0f1a · 6eb0f1a
1 parent f297979
commit 6eb0f1a
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 5 deletions.
diff --git a/packages/ui/app/src/mdx/components/layout/GuideLayout.tsx b/packages/ui/app/src/mdx/components/layout/GuideLayout.tsx
@@ -53,7 +53,7 @@ export function GuideLayout({
             </aside>
             <article className="fern-layout-content max-w-content-width">
                 <PageHeader breadcrumbs={breadcrumbs} title={title} subtitle={subtitle} />
-                <section className="max-w-full fern-prose">{children}</section>
+                <div className="max-w-full fern-prose">{children}</div>
                 {(!hideFeedback || !hideNavLinks || editThisPageUrl != null) && (
                     <footer className="mt-12">
                         <div className="flex sm:justify-between max-sm:flex-col gap-4">

diff --git a/packages/ui/app/src/mdx/components/layout/OverviewLayout.tsx b/packages/ui/app/src/mdx/components/layout/OverviewLayout.tsx
@@ -49,7 +49,7 @@ export function OverviewLayout({
             </aside>
             <article className="fern-layout-content max-w-content-wide-width">
                 <PageHeader breadcrumbs={breadcrumbs} title={title} subtitle={subtitle} />
-                <section className="max-w-full fern-prose">{children}</section>
+                <div className="max-w-full fern-prose">{children}</div>
                 {(!hideFeedback || editThisPageUrl != null) && (
                     <footer className="mt-12">
                         <div className="flex sm:justify-between max-sm:flex-col gap-4">

diff --git a/packages/ui/app/src/mdx/components/layout/PageLayout.tsx b/packages/ui/app/src/mdx/components/layout/PageLayout.tsx
@@ -38,7 +38,7 @@ export function PageLayout({
     return (
         <main className="fern-page-layout">
             <PageHeader breadcrumbs={breadcrumbs} title={title} subtitle={subtitle} />
-            <section className="max-w-full fern-prose">{children}</section>
+            <div className="max-w-full fern-prose">{children}</div>
             {(!hideFeedback || editThisPageUrl != null) && (
                 <footer className="mt-12">
                     <div className="flex sm:justify-between max-sm:flex-col gap-4">

diff --git a/packages/ui/app/src/mdx/components/layout/ReferenceLayout.tsx b/packages/ui/app/src/mdx/components/layout/ReferenceLayout.tsx
@@ -44,7 +44,7 @@ export function ReferenceLayout({
             <div className="z-10 w-full min-w-0 pt-8">
                 <article className="mx-auto w-full lg:ml-0 xl:mx-auto pb-20 max-w-content-width md:max-w-endpoint-width">
                     <PageHeader breadcrumbs={breadcrumbs} title={title} subtitle={subtitle} />
-                    <section
+                    <div
                         className={clsx("max-w-full prose dark:prose-invert prose-h1:mt-[1.5em] first:prose-h1:mt-0", {
                             "md:grid md:grid-cols-2 md:gap-8 lg:gap-12 max-md:space-y-12": isValidElement(aside),
                         })}
@@ -57,7 +57,7 @@ export function ReferenceLayout({
                                 </div>
                             </aside>
                         )}
-                    </section>
+                    </div>
                     {(!hideFeedback || editThisPageUrl != null) && (
                         <footer className="mt-12">
                             <div className="flex sm:justify-between max-sm:flex-col gap-4">