add tests for version dropdown

fern-api · Jun 3, 2024 · 1e570be · 1e570be
1 parent 3f3b709
commit 1e570be
Show file tree

Hide file tree

Showing 37 changed files with 137,693 additions and 35 deletions.
diff --git a/fern/apis/navigation/definition/__package__.yml b/fern/apis/navigation/definition/__package__.yml
@@ -120,6 +120,7 @@ types:
       - WithRedirect
     properties:
       type: literal<"version">
+      default: boolean
       versionId: VersionId
       child: VersionChild
       availability: optional<Availability>

diff --git a/packages/fdr-sdk/src/navigation/NodeCollector.ts b/packages/fdr-sdk/src/navigation/NodeCollector.ts
@@ -37,7 +37,7 @@ interface NavigationNodeWithMetadataAndParents {
 }
 
 export class NodeCollector {
-    private idToNode = new Map<FernNavigation.NodeId, NavigationNodeWithMetadata>();
+    private idToNode = new Map<FernNavigation.NodeId, NavigationNode>();
     private slugToNode: Record<FernNavigation.Slug, NavigationNodeWithMetadataAndParents> = {};
     private orphanedNodes: NavigationNodeWithMetadata[] = [];
 
@@ -62,6 +62,7 @@ export class NodeCollector {
 
     constructor(rootNode: NavigationNode) {
         traverseNavigation(rootNode, (node, _index, parents) => {
+            this.idToNode.set(node.id, node);
             if (node.type === "sidebarRoot") {
                 this.#last = undefined;
                 this.#lastNeighboringNode = undefined;
@@ -70,7 +71,6 @@ export class NodeCollector {
             if (!hasMetadata(node)) {
                 return;
             }
-            this.idToNode.set(node.id, node);
             const existing = this.slugToNode[node.slug];
             if (existing == null) {
                 this.#setNode(node.slug, node, parents);
@@ -114,7 +114,7 @@ export class NodeCollector {
         return this.getSlugMap();
     }
 
-    public get(id: FernNavigation.NodeId): NavigationNodeWithMetadata | undefined {
+    public get(id: FernNavigation.NodeId): NavigationNode | undefined {
         return this.idToNode.get(id);
     }
 
@@ -133,8 +133,8 @@ export class NodeCollector {
     });
 
     public getVersionNodes = once((): FernNavigation.VersionNode[] => {
-        return Object.values(this.slugToNode)
-            .filter(({ node }) => node.type === "version")
-            .map(({ node }) => node as FernNavigation.VersionNode);
+        return [...this.idToNode.values()]
+            .filter((node): node is FernNavigation.VersionNode => node.type === "version")
+            .map((node) => node);
     });
 }
diff --git a/packages/fdr-sdk/src/navigation/__test__/NavigationConfigConverter.test.ts b/packages/fdr-sdk/src/navigation/__test__/NavigationConfigConverter.test.ts
@@ -47,6 +47,10 @@ function testNavigationConfigConverter(fixtureName: string): void {
             expect(JSON.stringify([...pageIds], undefined, 2)).toMatchFileSnapshot(
                 `output/${fixtureName}/pageIds.json`,
             );
+
+            expect(JSON.stringify(slugCollector.getVersionNodes(), undefined, 2)).toMatchFileSnapshot(
+                `output/${fixtureName}/versionNodes.json`,
+            );
         });
     });
 }

diff --git a/packages/fdr-sdk/src/navigation/__test__/__snapshots__/polytomic.test.ts.snap b/packages/fdr-sdk/src/navigation/__test__/__snapshots__/polytomic.test.ts.snap
diff --git a/packages/fdr-sdk/src/navigation/__test__/fixtures/polytomic.json b/packages/fdr-sdk/src/navigation/__test__/fixtures/polytomic.json
diff --git a/packages/fdr-sdk/src/navigation/__test__/output/assemblyai/versionNodes.json b/packages/fdr-sdk/src/navigation/__test__/output/assemblyai/versionNodes.json
@@ -0,0 +1 @@
+[]
diff --git a/packages/fdr-sdk/src/navigation/__test__/output/astronomer/versionNodes.json b/packages/fdr-sdk/src/navigation/__test__/output/astronomer/versionNodes.json
@@ -0,0 +1 @@
+[]