Fixes #1636 Fixes "blank" enums by providing the fallback name #1829
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #1636
Some frameworks (e.g. django rest framework, I guess) generate following schema:
right now this library generates invalid typescript:
This happens in
getEnum
functions that don't check for invalid input (getEnum([''])
) in our case.I decided to give such enum values
BLANK
name so that generated files are correctNot sure if it would be a better idea to just omit these values (I mean, the name says BlankEnum) but everything's better than broken syntax