Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: Bump pyarrow to 1.6.0+ #639

Merged
merged 1 commit into from
Feb 14, 2025
Merged

lib: Bump pyarrow to 1.6.0+ #639

merged 1 commit into from
Feb 14, 2025

Conversation

aditya-nambiar
Copy link
Contributor

@aditya-nambiar aditya-nambiar commented Feb 14, 2025

Important

Bump pyarrow version to ^16.0.0 and update project version to 1.5.79.

  • Dependencies:
    • Bump pyarrow version to ^16.0.0 in pyproject.toml.
  • Versioning:
    • Update version to 1.5.79 in pyproject.toml.
    • Add changelog entry for version 1.5.79 in CHANGELOG.md.

This description was created by Ellipsis for 2112c7d. It will automatically update as commits are pushed.

Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 2112c7d in 2 minutes and 0 seconds

More details
  • Looked at 43 lines of code in 2 files
  • Skipped 1 files when reviewing.
  • Skipped posting 5 drafted comments based on config settings.
1. pyproject.toml:3
  • Draft comment:
    Version bump updated from 1.5.78 to 1.5.79. Ensure this change is reflected in all release notes.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50%
    None
2. pyproject.toml:24
  • Draft comment:
    pyarrow dependency updated to ^16.0.0. Confirm compatibility with existing code.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50%
    None
3. pyproject.toml:34
  • Draft comment:
    Dev-dependency pyarrow updated to ^16.0.0. Verify that test suite passes with new version.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50%
    None
4. fennel/CHANGELOG.md:3
  • Draft comment:
    Clarify pyarrow version: PR title mentions '1.6.0+' but changelog and dependencies specify '16.0.0'. Verify intended version.
  • Reason this comment was not posted:
    Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 0% vs. threshold = 50%
    The comment is asking for verification between PR title and changelog versions, but I can't see the PR title. More importantly, this type of verification request violates our rules - we should not ask authors to verify or confirm things. If there was a real version mismatch issue, it should be stated directly.
    I could be wrong about dismissing this - maybe there is a real version mismatch that needs to be fixed between the PR title and changelog.
    Even if there is a real version mismatch, asking for verification is not the right approach. The comment should either directly point out the error and request a specific fix, or be deleted.
    This comment should be deleted because it asks for verification rather than making a direct actionable statement, and I don't have enough context to verify if there's a real version mismatch issue.
5. pyproject.toml:24
  • Draft comment:
    pyarrow is declared in both dependencies and dev-dependencies; consider consolidating to avoid future version drift.
  • Reason this comment was not posted:
    Comment was on unchanged code.

Workflow ID: wflow_BnMZdakzADREKNfT


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@aditya-nambiar aditya-nambiar merged commit 69637ca into main Feb 14, 2025
8 checks passed
@aditya-nambiar aditya-nambiar deleted the aditya/bump-pyspark branch February 14, 2025 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants