Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to build on M1 #460

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

donaldguy
Copy link

@donaldguy donaldguy commented Aug 2, 2021

This is on the road to a #444 fix at least.

I also had to run brew install cocoapods; pod install and per instructions, swapped over to building out of the resulting Uebersicht.xcworkspace (but didn't commit most of the results)

and had to also do

diff --git a/Uebersicht/UBWindowsController.m b/Uebersicht/UBWindowsController.m
index 7e1e8ec..bad15e8 100644
--- a/Uebersicht/UBWindowsController.m
+++ b/Uebersicht/UBWindowsController.m
@@ -11,7 +11,6 @@
 #import "WKInspector.h"
 #import "WKView.h"
 #import "WKPage.h"
-#import "WKWebViewInternal.h"
 
 @import WebKit;
 

(as there is apparently a different / potentially conflicting definition brought in indirectly?; but that may be more a Monterey thing than an M1 thing )

still a bunch of warnings in the build, but the product has gotten me to:

CleanShot 2021-08-02 at 17 51 01@2x

so more than none-widgets are working (though not the one I was setting up, necessarily: thought that may have more to do with the also-changed path of yabai on arm)

@@ -555,7 +555,7 @@
);
runOnlyForDeploymentPostprocessing = 0;
shellPath = /bin/sh;
shellScript = "export PATH=$PATH:/usr/local/bin\ncd server && npm run-script release\n";
shellScript = "export PATH=$PATH:/usr/local/bin:/opt/homebrew/bin\ncd server && npm run-script release\n";
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

homebrew changed default path on arm64 - possibly cause at least for a while people were installing both x86_64 bins to rosetta and native ones - idk, there's probs a homebrew issue about it

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we probably here want to be in safe side and do PATH=/opt/homebrew/bin:/usr/local/bin:${PATH}
first we try arm64 path (we assume that if it exists we want to use it), then x86_64 one, and finally we consume whatever $PATH user has. this makes things IMHO a bit more predictable and deterministic.

@felixhageloh
Copy link
Owner

Thanks for the PR - it helped me to quickly pin down the issue with fsevents! There was some more work to be done to get Sparkle working, but I have a fully working build now (hopefully):

https://raw.githubusercontent.com/felixhageloh/uebersicht/gh-pages/releases/Uebersicht-1.6.71.app.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants