This repository has been archived by the owner on Aug 9, 2024. It is now read-only.
Fix invalid parameter error when calling euca-import-volume command #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pedro Moura <[email protected]>
markobrien1
reviewed
Feb 17, 2022
| @@ -166,7 +166,7 @@ def _create_volume(self, source): | |||
| if self.volume_via_s3: | |||
| output, err, retcode = external_run_command([ | |||
| 'euca-import-volume', | |||
| source, | |||
| source[5:], | |||
There was a problem hiding this comment.
Is this to strip /tmp/ from the source name due to the directory change?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes description
trigger_upload.pywasn't working because when it callseuca-import-volume, that command was throwing an error about an invalid format of the manifest url when concatenating it with the path of the file.This PR works around that problem because
euca-import-volumeworks just fine when executed directly from/tmpdirectory.Here is last lines of the log with those changes:
Related Issue
Signed-off-by: Pedro Moura [email protected]