Skip to content

Commit

Permalink
BUG: fix some line width bugs / UI issues
Browse files Browse the repository at this point in the history
- Use step="any" for the line width inputs, so that l.w. isn't
  restricted to just integers
- Change "Line Width" -> "Extra Line Width" in the UI
- Make the side panel reset functions set the line widths back to 0,
  not 1

there's still a weird thing where switching the layout makes the
new layout have thick lines, even if no thickening was previously
done. huh.
  • Loading branch information
fedarko committed Jul 18, 2020
1 parent 59a72bb commit 2f1f639
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 8 deletions.
4 changes: 2 additions & 2 deletions empress/support_files/js/side-panel-handler.js
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ define(["underscore", "Colorer", "util"], function (_, Colorer, util) {
sSel: { disabled: true },
sColor: { value: "discrete-coloring-qiime" },
sHideChk: { checked: false },
sLineWidth: { value: 1 },
sLineWidth: { value: 0 },
},
[this.sAddOpts, this.sUpdateBtn]
);
Expand All @@ -137,7 +137,7 @@ define(["underscore", "Colorer", "util"], function (_, Colorer, util) {
fChk: { checked: false },
fSel: { disabled: true },
fColor: { value: "discrete-coloring-qiime" },
fLineWidth: { value: 1 },
fLineWidth: { value: 0 },
fMethodChk: { checked: true },
},
[this.fAddOpts, this.fUpdateBtn]
Expand Down
12 changes: 6 additions & 6 deletions empress/support_files/templates/side-panel.html
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,9 @@
class="empress-input">
</p>
<p>
<label for="sample-line-width">Line Width</label>
<label for="sample-line-width">Extra Line Width</label>
<input id="sample-line-width" type="number" value="0" min="0"
class="empress-input">
step="any" class="empress-input">
</p>
<p>
<button id="sample-update" class="hidden">Update</button>
Expand Down Expand Up @@ -73,9 +73,9 @@
</label>
</p>
<p>
<label for="feature-line-width">Line Width</label>
<label for="feature-line-width">Extra Line Width</label>
<input id="feature-line-width" type="number" value="0" min="0"
class="empress-input">
step="any" class="empress-input">
</p>
<p>
<label for="fm-method-chk">Only use tip-level metadata?</label>
Expand Down Expand Up @@ -137,9 +137,9 @@
class="empress-input">
</p>
<p>
<label for="animate-line-width">Line Width</label>
<label for="animate-line-width">Extra Line Width</label>
<input id="animate-line-width" type="number" value="0" min="0"
class="empress-input">
step="any" class="empress-input">
</p>
<div>
<p>
Expand Down

0 comments on commit 2f1f639

Please sign in to comment.