Feature/1945 - Merge manifest files #1311
Conversation
| @@ -92,7 +92,7 @@ def _login_to_cf(ctx, space): | |||
|
|
|||
|
|
|||
| def _do_deploy(ctx, space, app): | |||
| manifest_filename = f"manifests/manifest-{space}-{MANIFEST_LABEL.get(app)}.yml" | |||
| manifest_filename = f"manifests/manifest-{space}.yml" | |||
There was a problem hiding this comment.
Let's get rid of MANIFEST_LABEL now that it's not used
There was a problem hiding this comment.
Oh good catch, always nice to remove dead content. Usually VSCode lets you know when something isn't used by turning it grey but for some reason it didn't this time. But double checked and it's definitely no longer used and can be safely removed.
manifests/manifest-prod.yml
Outdated
| memory: 2G | ||
| - name: fecfile-web-services | ||
| <<: *defaults | ||
| instances: 2 |
There was a problem hiding this comment.
I didn't catch this when we made the migrator and scheduler, but we want 0 instances for all apps in prod for now
There was a problem hiding this comment.
Oh good to know, I was trying to match what we currently have. Updated to set default to 0 on prod and not override it for any of them.
| SECONDARY_POLLING_DURATION: 86400 | ||
| # ---- FEATURE FLAGS ---- | ||
| FLAG__COMMITTEE_DATA_SOURCE: PRODUCTION # Values are PRODUCTION, TEST, and MOCKED | ||
| ENABLE_DEVELOPER_COMMANDS: False |
There was a problem hiding this comment.
Let's add FEC_AGENCY_ID: FEC from the old web-services environment varaibles. All the other environment variables are good
There was a problem hiding this comment.
Updated for all environments.
| SECONDARY_POLLING_DURATION: 86400 | ||
| # ---- FEATURE FLAGS ---- | ||
| FLAG__COMMITTEE_DATA_SOURCE: TEST # Values are PRODUCTION, TEST, and MOCKED | ||
| ENABLE_DEVELOPER_COMMANDS: True |
| SECONDARY_POLLING_DURATION: 86400 | ||
| # ---- FEATURE FLAGS ---- | ||
| FLAG__COMMITTEE_DATA_SOURCE: TEST # Values are TEST and PRODUCTION | ||
| ENABLE_DEVELOPER_COMMANDS: True |
|
Issue FECFILE-1945