6445 MUR citation filters #6588
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #6588 +/- ##
===========================================
- Coverage 79.72% 79.64% -0.08%
===========================================
Files 235 235
Lines 5159 5164 +5
===========================================
Hits 4113 4113
- Misses 1046 1051 +5 ☔ View full report in Codecov by Sentry. |
patphongs
requested changes
Jan 13, 2025
patphongs
reviewed
Jan 13, 2025
Comment on lines
146
to
148
| <input type="radio" id="citation_require_all_false" name="case_citation_require_all" value="false"{% if not case_citation_require_all %}checked{% endif %}> | ||
| <label for="citation_require_all_false">Show cases citing any of them</label> | ||
| <input type="radio" id="citation_require_all_true" name="case_citation_require_all" value="true"{% if case_citation_require_all %}checked{% endif %}> |
There was a problem hiding this comment.
The boolean for case_citation_require_all seems to always default to "Show cases citing all of them" regardless of which one the user chooses.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adding the citations filters for MURs searches
ALSO fixed a related oversight for AOs search
Required reviewers
Impacted areas of the application
Screenshots
Updated filter order:
The document date tooltip
Related PRs
None
How to test
npm run build