Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added ref prop to IconProps interface #79

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Added ref prop to IconProps interface #79

wants to merge 2 commits into from

Conversation

filingroove
Copy link

Fix for #78

@filingroove filingroove changed the title Switched type FC to ForwardRefRenderFunction in Icon Added ref prop to IconProps interface Dec 21, 2020
@elliott-king
Copy link

elliott-king commented Aug 29, 2022 •
edited
Loading

@carmelopullara apologies for the spam, just wanted to draw your attention. react-feather does not currently support refs with TS.

@amhunt
Copy link

amhunt commented Sep 29, 2023

@carmelopullara not urgent, but any chance we could merge this one? We're also experiencing a TS error here

@tounsoo
Copy link

tounsoo commented Apr 6, 2024

Following this

@tounsoo
Copy link

tounsoo commented Apr 28, 2024 •
edited
Loading

With React19, it looks like ref is now included.
React19 beta announcement / ref as prop

I also found type issue while testing out react19 and have reported the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@filingroove @elliott-king @amhunt @tounsoo