Export error sentinel values and refactor #25
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chore: Upgrade gomod to Go 1.21. perf: Ireallocate slice in `(*Tags).Keys()`. test: Add more tests and improve test coverage. refactor: Use github.com/stretchr/testify to simplify tests. refactor: Use black-box testing (test package with "_test" suffix). refactor: Use generic slice search function to reduce code duplication.
|
Hi @romshark Thank you for the PR. However I'm not interested in any other refactor, nor do I want to change the test package. Our goal is to export the Errors. Could you please open a new PR with only the actual changes we talked about ? Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chore: Upgrade gomod to Go 1.21.
perf: Preallocate slice in
(*Tags).Keys().test: Add more tests and improve test coverage.
test: Move syntax error testing to
TestParseErr.refactor: Use github.com/stretchr/testify to simplify tests.
refactor: Use black-box testing (test package with "_test" suffix).
refactor: Use generic slice search function to reduce code duplication.
A little more than promised, but I hope you're fine with these changes living in 1 PR (saved me time).
Please let me know if you want these changes to be split across multiple PRs.
resolves #24