New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove unnecessary slots labels #48129

Merged

jkarneges merged 1 commit into main from jkarneges/remove-slots-labels

Feb 19, 2025

Member

jkarneges commented Feb 19, 2025 •

edited

Loading

After this, the remaining use of slots: in non-deprecated modules will be:

Marking C++ tests as required by Qt's test harness.
SocketNotifier, (R)Timer, and DeferCall, due to internal use of Qt types.
ProcessQuit, in unused code (Windows Ctrl-C handler).
Proxy worker/domainmap thread management using QMetaObject::invokeMethod for cross-thread communication.

Note: we are not using signals: labels in any non-deprecated modules.


          remove unnecessary slots labels

deg4uss3r approved these changes

View reviewed changes

jkarneges merged commit 67e663b into main

19 checks passed

jkarneges deleted the jkarneges/remove-slots-labels branch

February 19, 2025 20:32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet