add http-check and http-modify filters #48089
Conversation
jkarneges
force-pushed
the
jkarneges/http-filter
branch
from
5fc4533 to
d76c190
Compare
jkarneges
force-pushed
the
jkarneges/http-filter
branch
2 times, most recently
from
e14e36f to
92f2a6d
Compare
jkarneges
force-pushed
the
jkarneges/http-filter
branch
from
92f2a6d to
fd8885f
Compare
jkarneges
force-pushed
the
jkarneges/http-filter
branch
2 times, most recently
from
a7886f9 to
9a8e000
Compare
jkarneges
force-pushed
the
jkarneges/http-filter
branch
from
9a8e000 to
19f56ac
Compare
| while(it.hasNext()) | ||
| { | ||
| it.next(); | ||
| vmap[it.key()] = it.value(); | ||
| } |
There was a problem hiding this comment.
This feels like an odd construction. I don't have the context on exactly what you are doing here but it looks like you are skipping the first item in the iterator by calling it.next() before copying. Is that intentional? I guess it must be, but maybe a comment as to what you are skipping might help make this look a little less odd! Same with the two loops that follow.
There was a problem hiding this comment.
The iterator requires calling next() to access the first item, so the code is intentional and not skipping the first item. It's a quirk of Qt's unintuitive "Java-style" API:
Unlike STL-style iterators, Java-style iterators point between items rather than directly at items. The first call to next() advances the iterator to the position between the first and second item, and returns the first item; the second call to next() advances the iterator to the position between the second and third item; and so on.
There was a problem hiding this comment.
Huh! What an odd interface! Well, that makes sense - thanks for explaining it.
This adds two new message filters that allow delegating filtering logic to an HTTP server:
http-check: Sends metadata only (no message content) to the server, to determine the action (send or drop).http-modify: Sends metadata and message content to the server, to determine the action and potentially have the content modified.For both filters, the target endpoint is specified using the subscription metadata field
url. Requests use thePOSTmethod and containSub-Meta,Pub-Meta, andGrip-Lastheaders. For thehttp-modifyfilter, the message content is included in the body (http-checkfilter leaves the body empty). The server is expected to reply with a status code 200 or 204, and optionally anAction: dropheader to indicate a drop action. Forhttp-modify, code 200 means the replacement content is in the response body, and code 204 means no change to the content.