handler: make message filtering async-capable #48088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkarneges
changed the title
jkarneges
force-pushed
the
jkarneges/async-filters
branch
from
7f938e3 to
693165a
Compare
jkarneges
changed the title
jkarneges
force-pushed
the
jkarneges/async-filters
branch
from
693165a to
8ed402d
Compare
deg4uss3r
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces the
MessageFilterclass for implementing async filtering operations, specifically for messages. Response content (formerly "proxy" content) must still be filtered using the synchronousFilterAPI.There are no actual async filters implemented yet, although all of the existing synchronous filters have been updated to derive from
MessageFilterand emit async results immediately. This way we can start using the async API in connection handlers.Longer term, the plan is to introduce a
ResponseFilterclass for similarly handling response content, and then turnFilterinto a namespace. In preparation for this,MessageFilterand related types are nested under theFilterclass.The goal of this reworking is not only to enable async operations but also to make the filtering API more clear. Instead of a single class with different modes, we'll have different classes with single modes.