boostification of all websocket signals

[sima-fastly]

boostification of all websocket signals

tested manually

[sima-fastly]

@jkarneges I have updated the code to delete connection struct instace when a req/sock gets deleted.

but this reminds me there are other places such as this file :
https://github.com/fastly/pushpin/blob/adf96ae5692c8c45e6835b40ea4dfb51f588142f/src/cpp/proxy/requestsession.cpp#L238C4-L238C23
where a req or socket are getting deleted without the corresponding connection getting disconnected. Am I correct in thinking these also need a disconnect statement fix?

[jkarneges]

Ah yeah, anywhere an object is deleted that might have had connections, especially if the deletion is done from somewhere that isn't the destructor and the object pointer is also nulled out, any connections should also be disconnected.

I suggest keeping the connections object as a value and not a pointer, or else you'll need to null out the connections object too. The connection object is initially implicitly constructed using its default constructor, so explicitly calling the default constructor later on should return it to its initial state.

[sima-fastly]

Ah yeah, anywhere an object is deleted that might have had connections, especially if the deletion is done from somewhere that isn't the destructor and the object pointer is also nulled out, any connections should also be disconnected.

I suggest keeping the connections object as a value and not a pointer, or else you'll need to null out the connections object too. The connection object is initially implicitly constructed using its default constructor, so explicitly calling the default constructor later on should return it to its initial state.

I have addressed this and will have a follow up PR to clean these up in other files