Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile: force phony targets #47854

Merged
merged 1 commit into from
Jan 4, 2024
Merged

Makefile: force phony targets #47854

merged 1 commit into from
Jan 4, 2024

Conversation

jkarneges
Copy link
Member

No description provided.

Copy link
Contributor

@sima-fastly sima-fastly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if these are phony targets why not do sth like this:
.PHONY: build cargo-test ...

@jkarneges
Copy link
Member Author

I noticed the qmake-generated makefiles are doing it this way, which seems to be for compatibility with non-GNU make. So just some defensive coding. That said, I don't know if our makefiles actually work with any non-GNU makes.

@jkarneges jkarneges merged commit 916ff90 into main Jan 4, 2024
1 check passed
@jkarneges jkarneges deleted the jkarneges/makefile-force branch January 4, 2024 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants