use std::dynamic_pointer_cast and guard wssession publish

fastly · Feb 18, 2025 · 40bc3ae · 40bc3ae
1 parent 9734faf
commit 40bc3ae
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/src/handler/handlerengine.cpp b/src/handler/handlerengine.cpp
@@ -1775,9 +1775,9 @@ class HandlerEngine::Private : public QObject
 
 	void publishSend(const std::shared_ptr<QObject> &target, const PublishItem &item, const QList<QByteArray> &exposeHeaders)
 	{
-		if(HttpSession *hs = dynamic_cast<HttpSession*>(target.get()))
+		if(auto hs = std::dynamic_pointer_cast<HttpSession>(target))
 			hs->publish(item, exposeHeaders);
-		else if(WsSession *s = dynamic_cast<WsSession*>(target.get()))
+		else if(auto s = std::dynamic_pointer_cast<WsSession>(target))
 			s->publish(item);
 	}
 

diff --git a/src/handler/wssession.cpp b/src/handler/wssession.cpp
@@ -105,6 +105,11 @@ void WsSession::ack(int reqId)
 
 void WsSession::publish(const PublishItem &item)
 {
+	const PublishFormat &f = item.format;
+
+	if(f.type != PublishFormat::WebSocketMessage)
+		return;
+
 	publishQueue += item;
 
 	if(!inProcessPublishQueue)