This repository has been archived by the owner on Mar 29, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 3
[WIP] Proposal to add a checkbox for "Is this a regression" #1
Open
joshdholtz
wants to merge
31
commits into
fastlane:master
Choose a base branch
from
joshdholtz:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We get a slack notification when an issue has a title or body that contains regression which is 👍 but only if people know to actually put "regression" in the title or the body. I would like to propose adding a "checkbox" (see below) to the GitHub Issue Template for people to fill in the checkbox if it is a regression.
GitHub Issue Template Addition
Other Thoughts
Possible Problems
This may introduce more alerts for regressions that aren't actually regressions but that might be okay so regressions are something that we definitely want to be aware of.
Other Possible Solutions
If we do not want to go this route of having a checkbox, we could simply add a comment like the following to the GitHub Issue Template.