Updated iPad Pro images to 3rd Gen #8
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
|
I signed it! |
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
|
Where do these images comes from @mikelrob? What is their license? |
|
Images were downloaded from Apple's Market Resources Site License Info can be found at https://www.apple.com/legal/intellectual-property/guidelinesfor3rdparties.html |
|
Hmm, that license says Note: You must obtain express written permission from Apple before using any photograph owned or licensed by Apple. But the developer site says Use Apple-provided product images in all your marketing materials to display your app on the Apple devices it supports, so that seems like express written permission to me. |
It would be preferable to have all the devices available for automated screenshotting and framing, however I don't think the
The developer site recommends: |
Apologies, I have been working with fastlane version 2.117.0. I have only recently seen the PRs |
|
No worries, it's a confusing mess what Apple created here by having the same resolution for two devices. We are trying hard to find workarounds, but it takes some time to get all the pieces to the correct place. |
|
Any update on this? :-) |
There was a problem hiding this comment.
Frames unfortunately can't be added to this repo manually, as this repo is filled via a process: https://github.com/fastlane/fastlane/tree/master/frameit/frames_generator
|
@mikelrob What were the manual steps you took after downloading the images from Apple's site? Maybe we can incorporate these as an additional step to the Facebook Design frame into our frames generator. |
First I had to remove the colour fill within the screen area by reducing it's alpha to zero. |
|
Meh, that doesn't sound too good for automation on our side. Maybe the licence allows you to re-host the files on a repository of yours so we can use that one where you already did this work? |
|
I'd refer back to @getaaron's fine investigative work again where he highlighted:
Reads to me like Apple allow developers to use their supplied image. I don't see any specific exclusions about hosting the image. |
Adds offsets for new assets Updates files.json Updates version.txt Adds version directory
|
@janpio I have reinstated the original iPad Pro assets and added the new assets named with the disambiguation file name added to |
…ng convention Updates files.json, offsets.json and version appropriately
|
Any updates on this? 😁 |
|
No :( |
|
I think the only change still needed is to make the script at https://github.com/fastlane/fastlane/blob/master/frameit/frames_generator/Rakefile download the new assets from somewhere? |
|
Download and create the offset json data automatically, yes. |
|
My apologies on not seeing this PR 😱 Going to close this since out of date but I’m keep a better on on things here now and will get future PRs merged faster 💪 |
No description provided.