👷 Update Playwright CI and Docker Compose to use depends on backend a…

…nd mailcatcher (#468)
fastapi · Oct 26, 2024 · caff0cc · caff0cc
1 parent d41aecb
commit caff0cc
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/.github/workflows/playwright.yml b/.github/workflows/playwright.yml
@@ -72,7 +72,6 @@ jobs:
       env:
         DEPOT_PROJECT_ID: ${{ vars.DEPOT_PROJECT_ID }}
     - run: docker compose down -v --remove-orphans
-    - run: docker compose up -d --wait backend
     - name: Run Playwright tests
       run: docker compose run --rm playwright npx playwright test --fail-on-flaky-tests --trace=retain-on-failure --shard=${{ matrix.shardIndex }}/${{ matrix.shardTotal }}
     - run: docker compose down -v --remove-orphans

diff --git a/compose.yml b/compose.yml
@@ -158,6 +158,9 @@ services:
         - VITE_API_URL=http://backend:8000
         - NODE_ENV=production
     ipc: host
+    depends_on:
+      - backend
+      - mailcatcher
     environment:
       - VITE_API_URL=http://backend:8000
       - MAILCATCHER_HOST=http://mailcatcher:1080