Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spelling error in syncEngine.test.ts, shuttle.integration.test.ts, 11.fnameIndex.ts #2509

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix spelling error in syncEngine.test.ts, shuttle.integration.test.ts, 11.fnameIndex.ts #2509

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d8a0123
fix typos syncEngine.test.ts
Pricstas Jan 30, 2025
a0c67fc
fix typo shuttle.integration.test.ts
Pricstas Jan 30, 2025
01d14b5
fix typo 11.fnameIndex.ts
Pricstas Jan 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions apps/hubble/src/network/sync/syncEngine.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -502,13 +502,13 @@ describe("SyncEngine", () => {
expect((await syncEngine.getDbStats()).numFnames).toEqual(0);
});
test("removes deleted fname proofs", async () => {
const supercedingUserNameProof = Factories.UserNameProof.build({
const supersedingUserNameProof = Factories.UserNameProof.build({
name: userNameProof.name,
timestamp: userNameProof.timestamp + 10,
});

expect(await syncEngine.trie.exists(SyncId.fromFName(userNameProof))).toBeFalsy();
expect(await syncEngine.trie.exists(SyncId.fromFName(supercedingUserNameProof))).toBeFalsy();
expect(await syncEngine.trie.exists(SyncId.fromFName(supersedingUserNameProof))).toBeFalsy();
expect((await syncEngine.getDbStats()).numFnames).toEqual(0);

await engine.mergeUserNameProof(userNameProof);
Expand All @@ -517,11 +517,11 @@ describe("SyncEngine", () => {
expect(await syncEngine.trie.exists(SyncId.fromFName(userNameProof))).toBeTruthy();
expect((await syncEngine.getDbStats()).numFnames).toEqual(1);

await engine.mergeUserNameProof(supercedingUserNameProof);
await engine.mergeUserNameProof(supersedingUserNameProof);
await sleepWhile(() => syncEngine.syncTrieQSize > 0, SLEEPWHILE_TIMEOUT);

expect(await syncEngine.trie.exists(SyncId.fromFName(userNameProof))).toBeFalsy();
expect(await syncEngine.trie.exists(SyncId.fromFName(supercedingUserNameProof))).toBeTruthy();
expect(await syncEngine.trie.exists(SyncId.fromFName(supersedingUserNameProof))).toBeTruthy();
expect((await syncEngine.getDbStats()).numFnames).toEqual(1);
});

Expand Down
2 changes: 1 addition & 1 deletion apps/hubble/src/storage/db/migrations/11.fnameIndex.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import { ResultAsync } from "neverthrow";
const log = logger.child({ component: "fnameIndex" });

/**
* Up untill now, we were accidentally writing the fid index for the fname messages as Little Endian
* Up until now, we were accidentally writing the fid index for the fname messages as Little Endian
* instead of Big Endian in name_registry_events.rs:make_fname_username_proof_by_fid_key.
* This migration will fix that to be big endian, and also remove the little endian index keys
*/
Expand Down
2 changes: 1 addition & 1 deletion packages/shuttle/src/shuttle.integration.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -561,7 +561,7 @@ describe("shuttle", () => {
}),
);
},
getAllVerficationMessagesByFid: async (
getAllVerificationMessagesByFid: async (
_request: FidRequest,
_metadata: Metadata,
_options: Partial<CallOptions>,
Expand Down