Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow uppercase x usernames #2490

Closed

Conversation

aditiharini
Copy link
Contributor

@aditiharini aditiharini commented Jan 23, 2025

Why is this change needed?

We don't allow x usernames with uppercase letters that are valid.

Merge Checklist

Choose all relevant options below by adding an x now or at any time before submitting for review


PR-Codex overview

This PR introduces new message pruning functionality to the system, including new request and response message types in the protocol and related RPC methods. It also updates various components to support this new feature.

Detailed summary

  • Added PruneMessagesRequest and PruneMessagesResponse messages in protobufs/schemas/request_response.proto.
  • Implemented PruneMessages RPC method in protobufs/schemas/rpc.proto.
  • Updated packages/shuttle/src/shuttle/index.ts to export migration functionality.
  • Modified TWITTER_REGEX in packages/core/src/validations.ts for case sensitivity.
  • Changed the cron schedule for DEFAULT_PRUNE_MESSAGES_JOB_CRON in apps/hubble/src/storage/jobs/pruneMessagesJob.ts.
  • Enhanced logging for message operations in apps/hubble/src/utils/logger.ts.
  • Introduced clearCachedMessageCount method in apps/hubble/src/storage/stores/storeEventHandler.ts.
  • Updated environment variables in apps/hubble/src/example-app/env.ts.
  • Added stopTransferId parameter to constructor in apps/hubble/src/eth/fnameRegistryEventsProvider.ts.
  • Added new RPC methods for submitUserNameProof and pruneMessages in apps/hubble/src/rpc/adminServer.ts.
  • Implemented message handling for pruning in apps/hubble/src/storage/engine/index.ts.
  • Created migration functionality in packages/shuttle/src/shuttle/migration.ts to handle on-chain events and username proofs.
  • Updated message reconciliation logic in packages/shuttle/src/shuttle/messageReconciliation.ts.
  • Enhanced error handling and logging throughout the codebase.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented Jan 23, 2025

⚠️ No Changeset found

Latest commit: 343508b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Jan 23, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hub-monorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 23, 2025 0:30am

@aditiharini aditiharini added the t-bug A fix for a bug with the current system label Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t-bug A fix for a bug with the current system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants