-
Notifications
You must be signed in to change notification settings - Fork 475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow uppercase x usernames #2490
allow uppercase x usernames #2490
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Why is this change needed?
We don't allow x usernames with uppercase letters that are valid.
Merge Checklist
Choose all relevant options below by adding an
x
now or at any time before submitting for reviewPR-Codex overview
This PR introduces new message pruning functionality to the system, including new request and response message types in the protocol and related RPC methods. It also updates various components to support this new feature.
Detailed summary
PruneMessagesRequest
andPruneMessagesResponse
messages inprotobufs/schemas/request_response.proto
.PruneMessages
RPC method inprotobufs/schemas/rpc.proto
.packages/shuttle/src/shuttle/index.ts
to export migration functionality.TWITTER_REGEX
inpackages/core/src/validations.ts
for case sensitivity.DEFAULT_PRUNE_MESSAGES_JOB_CRON
inapps/hubble/src/storage/jobs/pruneMessagesJob.ts
.apps/hubble/src/utils/logger.ts
.clearCachedMessageCount
method inapps/hubble/src/storage/stores/storeEventHandler.ts
.apps/hubble/src/example-app/env.ts
.stopTransferId
parameter to constructor inapps/hubble/src/eth/fnameRegistryEventsProvider.ts
.submitUserNameProof
andpruneMessages
inapps/hubble/src/rpc/adminServer.ts
.apps/hubble/src/storage/engine/index.ts
.packages/shuttle/src/shuttle/migration.ts
to handle on-chain events and username proofs.packages/shuttle/src/shuttle/messageReconciliation.ts
.