Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: snapchain migration #2443

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from
Prev Previous commit
remove fname retry
aditiharini committed Jan 22, 2025
commit 5a603de958c5d33876f3101f651c2ba34a47f5a8
22 changes: 11 additions & 11 deletions apps/hubble/src/storage/engine/index.ts
Original file line number Diff line number Diff line change
@@ -1038,17 +1038,17 @@ class Engine extends TypedEmitter<EngineEvents> {

const result = await ResultAsync.fromPromise(this._userDataStore.getUserNameProof(name), (e) => e as HubError);

if (result.isErr() && result.error.errCode === "not_found" && retries > 0 && this._fNameRegistryEventsProvider) {
const rateLimitResult = await ResultAsync.fromPromise(
this._fNameRetryRateLimiter.consume(0),
() => new HubError("unavailable", "Too many requests to fName server"),
);
if (rateLimitResult.isErr()) {
return err(rateLimitResult.error);
}
await this._fNameRegistryEventsProvider.retryTransferByName(name);
return this.getUserNameProof(name, retries - 1);
}
// if (result.isErr() && result.error.errCode === "not_found" && retries > 0 && this._fNameRegistryEventsProvider) {
// const rateLimitResult = await ResultAsync.fromPromise(
// this._fNameRetryRateLimiter.consume(0),
// () => new HubError("unavailable", "Too many requests to fName server"),
// );
// if (rateLimitResult.isErr()) {
// return err(rateLimitResult.error);
// }
// await this._fNameRegistryEventsProvider.retryTransferByName(name);
// return this.getUserNameProof(name, retries - 1);
// }

return result;
}