Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove node 20 from CI #2419

Merged
merged 2 commits into from
Dec 7, 2024

Conversation

sanjayprabhu
Copy link
Contributor

@sanjayprabhu sanjayprabhu commented Dec 7, 2024

Why is this change needed?

Remove node 20

Merge Checklist

Choose all relevant options below by adding an x now or at any time before submitting for review


PR-Codex overview

This PR updates the ci.yml workflow configuration for the GitHub Actions CI pipeline, specifically adjusting the node_version and runs_on parameters for different runner environments.

Detailed summary

  • Added node_version: 20 to the matrix.include.
  • Changed runs_on for the first configuration to ['runs-on=${{ github.run_id }}', 'runner=4cpu-linux-x64'].
  • Updated runs_on for the second configuration to ['runs-on=${{ github.run_id }}', 'runner=4cpu-linux-arm64'].
  • Retained node_version: 22.4.1 with a comment regarding an issue with node 22.7.0.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@sanjayprabhu sanjayprabhu added the t-chore Miscellaneous improvements label Dec 7, 2024
Copy link

changeset-bot bot commented Dec 7, 2024

⚠️ No Changeset found

Latest commit: cf88e33

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Dec 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hub-monorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 7, 2024 7:27am

@sanjayprabhu sanjayprabhu merged commit 79a463d into farcasterxyz:main Dec 7, 2024
5 of 7 checks passed
@sanjayprabhu sanjayprabhu deleted the remove_node_20 branch December 7, 2024 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t-chore Miscellaneous improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant