Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix http api example #1640

Merged
merged 1 commit into from
Feb 23, 2024
Merged

Fix http api example #1640

merged 1 commit into from
Feb 23, 2024

Conversation

timjrobinson
Copy link
Contributor

@timjrobinson timjrobinson commented Feb 2, 2024

Change Summary

  • The latest version of Axios returns the body in response.data so we need to pull messages out of there.

Merge Checklist

Choose all relevant options below by adding an x now or at any time before submitting for review


PR-Codex overview

This PR focuses on fixing a bug in the code related to accessing the text of the first cast in the API response.

Detailed summary

  • Updated code to access the text of the first cast in the API response by correcting the object path.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

- The latest version of Axios returns the body in `response.data` so we
  need to pull messages out of there.
Copy link

changeset-bot bot commented Feb 2, 2024

⚠️ No Changeset found

Latest commit: 799d0af

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Feb 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hub-monorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 2, 2024 5:39am

@sds sds added the t-docs Add or update documentation label Feb 23, 2024
@sds
Copy link
Member

sds commented Feb 23, 2024

Thanks!

@sds sds merged commit 7f68b62 into farcasterxyz:main Feb 23, 2024
5 of 8 checks passed
@timjrobinson timjrobinson deleted the fix-http-example branch April 1, 2024 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t-docs Add or update documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants