fix: Handle docker-compose versions #1581
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
On some versions of docker-compose, the
docker compose ps
command returns true (0), but if you specify a not-running container, it returns false (1), making it incorrectly think docker compose is not installed.Fix by just checking for docker compose
Change Summary
Merge Checklist
Choose all relevant options below by adding an
x
now or at any time before submitting for reviewPR-Codex overview
This PR focuses on fixing an issue with handling docker-compose versions in the
hubble.sh
script.Detailed summary
@farcaster/hubble
dependency.hubble.sh
script to handle docker-compose versions correctly.grafana/data
file to allow execution.