Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Handle docker-compose versions #1581

Merged
merged 1 commit into from
Nov 13, 2023
Merged

Conversation

adityapk00
Copy link
Contributor

@adityapk00 adityapk00 commented Nov 11, 2023

Motivation

On some versions of docker-compose, the docker compose ps command returns true (0), but if you specify a not-running container, it returns false (1), making it incorrectly think docker compose is not installed.

Fix by just checking for docker compose

Change Summary

  • Don't pass container name when checking for docker-compose

Merge Checklist

Choose all relevant options below by adding an x now or at any time before submitting for review


PR-Codex overview

This PR focuses on fixing an issue with handling docker-compose versions in the hubble.sh script.

Detailed summary

  • Added a patch for the @farcaster/hubble dependency.
  • Modified the hubble.sh script to handle docker-compose versions correctly.
  • Changed the permissions of the grafana/data file to allow execution.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented Nov 11, 2023

🦋 Changeset detected

Latest commit: 13f0281

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@farcaster/hubble Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Nov 11, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hub-monorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 11, 2023 11:25pm

Copy link

codecov bot commented Nov 11, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

see 2 files with indirect coverage changes

📢 Thoughts on this report? Let us know!

@adityapk00 adityapk00 merged commit 6bfb694 into farcasterxyz:main Nov 13, 2023
@adityapk00 adityapk00 deleted the fix-dc branch November 13, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants