-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Freshjenkins #3
Open
fapestniegd
wants to merge
4
commits into
master
Choose a base branch
from
freshjenkins
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Freshjenkins #3
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
2c6f931
Adding sources list file to jenkins module
7b868ba
Adding init.pp manifests with changes to get a fresh version of jenkins
8be2555
Added absolute binary path to add_jenkins_signature line so we can ad…
6232fa6
Mispelled 'sources' in the path in places when adding the lists file
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
deb http://pkg.jenkins-ci.org/debian binary/ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,36 @@ | ||
#init.pp for adding jenkins with latest version | ||
|
||
#Class that rolls it all together | ||
class jenkins { | ||
package { 'jenkins': | ||
ensure => installed, | ||
ensure => latest, | ||
require => [ | ||
File['/etc/apt/sources.list.d/jenkins.list'], | ||
Exec['add_jenkins_signature'], | ||
Exec['jenkins_apt_get_update'] | ||
] | ||
|
||
} | ||
|
||
#create apt source list file for jenkins | ||
file { '/etc/apt/sources.list.d/jenkins.list': | ||
ensure => file, | ||
mode => '0644', | ||
owner => 'root', | ||
group => 'root', | ||
source => 'puppet:///modules/jenkins/etc/apt/sources.list.d/jenkins.list', | ||
} | ||
|
||
|
||
# Execute line for Adding Jenkins gpg signature to host | ||
exec {'add_jenkins_signature': | ||
command => "/usr/bin/wget -q -O - http://pkg.jenkins-ci.org/debian/jenkins-ci.org.key | /usr/bin/apt-key add -" | ||
} | ||
|
||
# Execute line for updating apt sources list after adding jenkins gpg key | ||
exec {'jenkins_apt_get_update': | ||
command => "/usr/bin/apt-get update" | ||
} | ||
|
||
|
||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you make this not run wget every time?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure. Could I get some help on re-writing the line? Not sure exactly how to go about doing that aside from possibly adding another file with the key directly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's exactly what' I'd do. Add it as a file resource.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But what if the file resource changes?