Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump core packages to v18.2.10 #54

Merged
merged 1 commit into from
Nov 10, 2024
Merged

Conversation

bougwal
Copy link
Collaborator

@bougwal bougwal commented Nov 3, 2024

Hi @falberthen Hope you are well ! I have been consumed by many commitments as end of the year is approaching. I just noticed that the repo is behind with v18 and I have bumped it. This allows us moving away from many "legacy" deprecated utilities in Angular. I'll try to update some of them in the code-base as soon as find time!

Please review the packages below whenever your time allows. Many thanks !

@bougwal bougwal force-pushed the spa/migrationv18.2.10 branch 2 times, most recently from a37e3e4 to a741483 Compare November 3, 2024 15:12
@bougwal bougwal requested a review from falberthen November 3, 2024 15:14
@falberthen falberthen force-pushed the spa/migrationv18.2.10 branch from d72e8e5 to b05fdf4 Compare November 6, 2024 01:51
@falberthen
Copy link
Owner

Hi @falberthen Hope you are well ! I have been consumed by many commitments as end of the year is approaching. I just noticed that the repo is behind with v18 and I have bumped it. This allows us moving away from many "legacy" deprecated utilities in Angular. I'll try to update some of them in the code-base as soon as find time!

Please review the packages below whenever your time allows. Many thanks!

Hi @bougwal! I'm fine, tks. I hope you're well as well. I pulled your branch to test the new packages and had to update the package-lock.json, which has been pushed. Can you check if it's all good so we can proceed with this PR?

Thank you!

@bougwal bougwal force-pushed the spa/migrationv18.2.10 branch from b05fdf4 to 51867ac Compare November 9, 2024 16:54
@bougwal
Copy link
Collaborator Author

bougwal commented Nov 9, 2024

LGTM @falberthen ! Many thanks for the commit, I am squashing/ force pushing and we are good to merge 🚀

@falberthen falberthen self-assigned this Nov 10, 2024
@falberthen falberthen merged commit 7a25fc3 into master Nov 10, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants