Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: simplify rest client #78

Merged
merged 2 commits into from
Feb 1, 2024
Merged

chore: simplify rest client #78

merged 2 commits into from
Feb 1, 2024

Conversation

mederka
Copy link
Contributor

@mederka mederka commented Feb 1, 2024

No description provided.

@mederka mederka requested a review from chamini2 February 1, 2024 15:06
@mederka mederka force-pushed the update-fal-python-client branch from bcde30f to 899915c Compare February 1, 2024 15:09
@mederka mederka force-pushed the update-fal-python-client branch from 899915c to 25fe0eb Compare February 1, 2024 15:11
Copy link
Member

@chamini2 chamini2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mederka
Copy link
Contributor Author

mederka commented Feb 1, 2024

LGTM, you did check againt uses of openapi_fal_rest in the fal client itself? https://github.com/search?q=repo%3Afal-ai%2Ffal+openapi_fal_rest+NOT+path%3A%2F%5Eprojects%5C%2Ffal%5C%2Fopenapi-fal-rest%5C%2F%2F+&type=code

Yep, exactly! That's how I filtered the routes when generating openapi client.

@mederka mederka merged commit ee62c82 into main Feb 1, 2024
4 checks passed
@mederka mederka deleted the update-fal-python-client branch February 1, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants