feat(toolkit): support multipart for saving bytes #397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chamini2
reviewed
Jan 24, 2025
chamini2
reviewed
Jan 24, 2025
| @@ -672,7 +788,7 @@ def save_file( | |||
| multipart = os.path.getsize(file_path) > threshold | |||
|
|
|||
| if multipart: | |||
| url = self._save_multipart( | |||
| url = MultipartUpload.save_file( | |||
There was a problem hiding this comment.
since now .save handles this, you could just forward all the multipart-related args to it and leave the decision to save
There was a problem hiding this comment.
you mean to self.save? It only handles bytes though, but here we need to handle file, so that we don't read it all into memory.
chamini2
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.