-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(fal): support basic fal profiles #383
Conversation
Instead of |
@squat I'm familiar with platformdirs/appdirs and used them before heavily, but I would say that they are more confusing for cli applications. They are great for GUI and other stuff as they obide XDG conventions, but it gets way more confusing for simple cli-oriented applications and I would rather not use them. |
I ultimately don't care about platformdirs itself. My point is about using a config location that conforms to standards and user expectations, i.e. |
@squat The expectation is to have |
22ee517
to
3b5c647
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool!
BTW, I agree we should just keep it in ~/.fal
dir. if you are expected to modify the config, it should be very easy to find. Also, we already create the directory for Auth0 token
@@ -77,6 +77,7 @@ | |||
"uvicorn", | |||
"starlette_exporter", | |||
"structlog", | |||
"tomli", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oops, accident
Currently one needs to either
login
or keep usingFAL_KEY
env vars either implicitly or explicitly, but both can lead to confusion. In my case I find myself generating new keys all the time, because I can't remember which one was which. This PR introduces~/.fal/config.toml
orFAL_CONFIG_PATH
with profile sectionsFAL_PROFILE
to set particular profilewhich allows keeping keys in one place and then easily switching between them, similar to tools like aws cli or modal.
In the future we can also use this for acquiring list of teams that your account has access to and switching between them, similar to
modal profile
.