Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fal file #281

Merged
merged 8 commits into from
Aug 28, 2024
Merged

feat: fal file #281

merged 8 commits into from
Aug 28, 2024

Conversation

badayvedat
Copy link
Contributor

@badayvedat badayvedat commented Aug 21, 2024

Example part in a pyproject.toml

[tool.fal.apps.my-app]
ref = "inference.py::MyApp"
auth = "shared"

this will be converted to something like

fal deploy inference.py::MyApp --app-name my-app --auth shared

@badayvedat badayvedat changed the title wip: fal file [WIP] feat: fal file Aug 21, 2024
@badayvedat badayvedat changed the title [WIP] feat: fal file feat: fal file Aug 21, 2024
@efiop efiop self-requested a review August 21, 2024 13:40
return str(path_pyproject_toml)


def parse_pyproject_toml(path_config: str) -> Dict[str, Any]:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should eventually make this a typed dict or a data class so we have stronger typing and that way caller functions have guarantees about what fields they can expect to access

@efiop efiop merged commit c2a76bf into main Aug 28, 2024
6 checks passed
@efiop efiop deleted the vedat/fea-fal-file branch August 28, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants