refactor: fal file #16
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Daniel Rochetti <[email protected]>
badayvedat
force-pushed
the
refactor-fal-toolkit-file
branch
from
a0c81f4 to
4017985
Compare
mederka
previously approved these changes
Jan 19, 2024
There was a problem hiding this comment.
Great job, @badayvedat 👏
As discussed. I think that maybe the class name File is a bit misleading because in reality it's not referring to a file but to a link to a file. It works magically when it's used inside a fal runtime, but not so in users local environment. I like your idea of potentially renaming this class to FileUrl or FileLink.
Comment on lines
+59
to
+60
| with data.data as file: | ||
| gcp_blob.upload_from_file(file, content_type=data.content_type) |
There was a problem hiding this comment.
Will this work if filename == "" ?
There was a problem hiding this comment.
good catch! we should've raised an error in that case
mederka
previously approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.