Hdu reader skip rows #349
Hdu reader skip rows #349
Conversation
| @@ -35,6 +35,12 @@ | |||
| final DataInputStream tableDataStream; | |||
| DataInputStream heapDataStream = null; | |||
|
|
|||
| private final Header header; | |||
There was a problem hiding this comment.
I learned not to expose any variables outside so I did that here, but yeah it is final it can be public. Changed it and removed the getter.
| @@ -127,4 +127,8 @@ public Data readNext() throws Exception { | |||
|
|
|||
| return item; | |||
| } | |||
|
|
|||
| public Reader getReader() { | |||
There was a problem hiding this comment.
Is this just for tests? Then Reader could be package private and the getter is unnecessary
There was a problem hiding this comment.
I need this also later in the SamplePedestal processor but I changed it to a skipToRow function as this is the only thing I need. No reason to expose the whole reader.
| @Override | ||
| public void skipToRow(int num) throws IOException { | ||
| //calc zshrink problem | ||
| //num = num+1; |
There was a problem hiding this comment.
fixed the error and thus the problem with zshrink
…other small changes
| @@ -141,4 +143,13 @@ private Serializable readArrayFromStream(BinTable.TableColumn c, DataInputStream | |||
| } | |||
| return null; | |||
| } | |||
|
|
|||
| @Override | |||
| public void skipToRow(int num) throws IOException { | |||
There was a problem hiding this comment.
Can you write a little docstring here?
| @@ -127,4 +127,8 @@ public Data readNext() throws Exception { | |||
|
|
|||
| return item; | |||
| } | |||
|
|
|||
| public void skipToRow(int num) throws IOException{ | |||
| * @param num The amount of rows to skip. | ||
| * @throws IOException | ||
| */ | ||
| void skipToRow(int num) throws IOException; |
There was a problem hiding this comment.
It skips 'num' rows right? So if i call 'skipToRow(4)' twice in a row im looking at row 8 right? I propose to change the name of the method to simply 'skipRows'
There was a problem hiding this comment.
It skipped to the row from the beginning and could only be called from there, I changed it now to be able to skip rows whenever
|
As said in the reply to @mackaiver, the skipToRow function is now a skipRows function that allows to skip from any position in the file. |
|
Removed the commented lines. If this was all it should be ready for merge. |
Added the ability to skip rows in the HDU reader. This is nedded for the SamplePedestalEvent processor that is coming in a later pull request.
This is the second part of the pull request simplification of #246 and can be merged independently of #348.