Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

singlePulseExtractionImprovement: Define maxIterations #162

Open
jebuss opened this issue Nov 15, 2016 · 0 comments
Open

singlePulseExtractionImprovement: Define maxIterations #162

jebuss opened this issue Nov 15, 2016 · 0 comments
Assignees
@jebuss @relleums
Labels
enhancement Single-Pulse-Extraction

Comments

@jebuss
Copy link
Member

jebuss commented Nov 15, 2016 •
edited by dneise
Loading

Right now the maximum number of iterations is handover from the XML. For some events it might be far too many, for others far to less. I suggest to correlate this number with the maxAmplitude in the time window which is neglecting the time marker pulse.

I think we should not make this number a free parameter.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jebuss jebuss

@relleums relleums

Labels
enhancement Single-Pulse-Extraction
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@maxnoe @jebuss @relleums