Add predictions in the altaz frame #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add pointing alt/az/zd to read_apply columns - Add camera_to_horizontal function and cta transformation - Calculate and save alt/az predictions in apply_disp and apply_dxdy
Codecov Report
@@ Coverage Diff @@
## master #152 +/- ##
==========================================
+ Coverage 90.42% 90.58% +0.16%
==========================================
Files 37 37
Lines 3176 3241 +65
==========================================
+ Hits 2872 2936 +64
- Misses 304 305 +1
Continue to review full report at Codecov.
|
- Swapped alt/az in the apply scripts - Return altitude as opposed to zenith distance for fact
maxnoe
reviewed
Apr 7, 2021
maxnoe
reviewed
Apr 8, 2021
transformations - FACT uses zenith distance, CTA uses Altitude - Previously CTA transformations would work, but the output was labeled as zd, although it was in fact (pun intended) the altitude
maxnoe
reviewed
Apr 22, 2021
Sure |
maxnoe
approved these changes
May 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connected Issue: #149